Need pointer to implement CloseNotifier #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You’d be better off changing |
jprobinson
suggested changes
Jan 25, 2018
gzip_test.go
Outdated
| @@ -325,17 +325,35 @@ func TestFlushBeforeWrite(t *testing.T) { | |||
| } | |||
|
|
|||
| func TestImplementCloseNotifier(t *testing.T) { | |||
| request := &http.Request{} | |||
| request.Header = http.Header{} | |||
There was a problem hiding this comment.
Mind using https://golang.org/pkg/net/http/httptest/#NewRequest here instead of building the request and header in 2 lines?
jprobinson
approved these changes
Jan 25, 2018
|
🌭 🍕 thanks!! |
drewbailey
added a commit
to hashicorp/nomad
that referenced
this pull request
Oct 7, 2019
This version of gziphandler includes a fix that fixes GzipResponseWriter to implement CloseNotifier nytimes/gziphandler#63
drewbailey
added a commit
to hashicorp/nomad
that referenced
this pull request
Oct 15, 2019
This version of gziphandler includes a fix that fixes GzipResponseWriter to implement CloseNotifier nytimes/gziphandler#63
drewbailey
added a commit
to hashicorp/nomad
that referenced
this pull request
Oct 24, 2019
This version of gziphandler includes a fix that fixes GzipResponseWriter to implement CloseNotifier nytimes/gziphandler#63
drewbailey
added a commit
to hashicorp/nomad
that referenced
this pull request
Oct 25, 2019
This version of gziphandler includes a fix that fixes GzipResponseWriter to implement CloseNotifier nytimes/gziphandler#63
drewbailey
added a commit
to hashicorp/nomad
that referenced
this pull request
Oct 30, 2019
This version of gziphandler includes a fix that fixes GzipResponseWriter to implement CloseNotifier nytimes/gziphandler#63
drewbailey
added a commit
to hashicorp/nomad
that referenced
this pull request
Nov 1, 2019
This version of gziphandler includes a fix that fixes GzipResponseWriter to implement CloseNotifier nytimes/gziphandler#63
drewbailey
added a commit
to hashicorp/nomad
that referenced
this pull request
Nov 4, 2019
This version of gziphandler includes a fix that fixes GzipResponseWriter to implement CloseNotifier nytimes/gziphandler#63
drewbailey
added a commit
to hashicorp/nomad
that referenced
this pull request
Nov 5, 2019
This version of gziphandler includes a fix that fixes GzipResponseWriter to implement CloseNotifier nytimes/gziphandler#63
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GzipResponseWriterWithCloseNotify doesn't implement CloseNotifier, but *GzipResponseWriterWithCloseNotify does.
Fix the tests to really verify with a request that accept gzip.