Merge pull request #59 from NYTimes/fix-compass-report

fix compass position report
nytimes · Jul 20, 2017 · f9bd0df · f9bd0df
2 parents ed29537 + 8117d31
commit f9bd0df
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/Sources/NYT360CameraController.m b/Sources/NYT360CameraController.m
@@ -82,7 +82,7 @@ - (void)stopMotionUpdates {
 #pragma mark - Compass Angle
 
 - (float)compassAngle {
-    return NYT360CompassAngleForEulerAngles(self.pointOfView.eulerAngles, NYT360EulerAngleCalculationDefaultReferenceCompassAngle);
+    return NYT360CompassAngleForEulerAngles(self.pointOfView.eulerAngles);
 }
 
 #pragma mark - Camera Control

diff --git a/Sources/NYT360EulerAngleCalculations.h b/Sources/NYT360EulerAngleCalculations.h
@@ -48,4 +48,4 @@ CGFloat NYT360OptimalYFovForViewSize(CGSize viewSize);
  *
  *  Input values in excess of one rotation will be mapped to an equivalent value within the range of plus or minus one radian, such that output values will exceed one rotation. Input values equal (or very very close to equal) to a multiple of one radian (positive or negative) will be mapped to 0.
  */
-float NYT360CompassAngleForEulerAngles(SCNVector3 eulerAngles, float referenceAngle);
+float NYT360CompassAngleForEulerAngles(SCNVector3 eulerAngles);
diff --git a/Sources/NYT360EulerAngleCalculations.m b/Sources/NYT360EulerAngleCalculations.m
@@ -11,7 +11,7 @@
 #pragma mark - Constants
 
 CGFloat const NYT360EulerAngleCalculationNoiseThresholdDefault = 0.12;
-float const NYT360EulerAngleCalculationDefaultReferenceCompassAngle = 0;
+float const NYT360EulerAngleCalculationDefaultReferenceCompassAngle = 3.14;
 
 #pragma mark - Inline Functions
 
@@ -155,6 +155,6 @@ CGFloat NYT360OptimalYFovForViewSize(CGSize viewSize) {
     return yFov;
 }
 
-float NYT360CompassAngleForEulerAngles(SCNVector3 eulerAngles, float referenceAngle) {
-    return NYT360UnitRotationForCameraRotation((-1.0 * eulerAngles.y) + referenceAngle);
+float NYT360CompassAngleForEulerAngles(SCNVector3 eulerAngles) {
+    return NYT360UnitRotationForCameraRotation((-1.0 * eulerAngles.y) + NYT360EulerAngleCalculationDefaultReferenceCompassAngle);
 }