Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typeahead Tweaks #65

Merged
merged 2 commits into from Oct 9, 2019
Merged

Typeahead Tweaks #65

merged 2 commits into from Oct 9, 2019

Conversation

afischer
Copy link
Member

@afischer afischer commented Oct 8, 2019

Description of Change

  • Fixes issue where a document title may appear twice in the suggestion dropdown
  • Adjusts css to preserve styles when typeahead.js fails to load

Checklist

  • Ran npm run lint and updated code style accordingly
  • npm run test passes
  • PR has a description and all contributors/stakeholder are noted/cc'ed
  • tests are updated and/or added to cover new code
  • relevant documentation is changed and/or added

afischer
afischer commented Oct 8, 2019
View reviewed changes
styles/partials/core/_base.scss
@@ -28,6 +28,10 @@ a {

}

input {
box-sizing: border-box;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The lack of a css reset has messed with me a number of times — maybe we should consider adding some extremely simple resets?

isaacwhite
isaacwhite approved these changes Oct 9, 2019
View reviewed changes
Copy link
Member

@isaacwhite isaacwhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. Thanks, @afischer!

@isaacwhite isaacwhite merged commit f9ecfac into master Oct 9, 2019
@isaacwhite isaacwhite deleted the typeahead-fixes branch October 10, 2019 03:06
@chrisfrank chrisfrank mentioned this pull request Oct 11, 2019
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isaacwhite isaacwhite isaacwhite approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@afischer @isaacwhite