Merge pull request #104 from nytimes/fix-editor-effect-destroy

Return effect result from useEditorEffect.
nytimes · Feb 23, 2024 · 124010f · 124010f
2 parents 2f40821 + a2f82d1
commit 124010f
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/.yarn/versions/00b65457.yml b/.yarn/versions/00b65457.yml
@@ -0,0 +1,2 @@
+releases:
+  "@nytimes/react-prosemirror": patch
diff --git a/src/hooks/useEditorEffect.ts b/src/hooks/useEditorEffect.ts
@@ -34,7 +34,9 @@ export function useEditorEffect(
   // be defined inline and run on every re-render.
   useLayoutGroupEffect(
     () => {
-      if (editorView) effect(editorView);
+      if (editorView) {
+        return effect(editorView);
+      }
     },
     // The rules of hooks want to be able to statically
     // verify the dependencies for the effect, but this will