Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up imports by linting them for consistency and correctness #109

Merged
merged 1 commit into from
Feb 24, 2024

Conversation

tilgovi
Copy link
Contributor

@tilgovi tilgovi commented Feb 23, 2024

  • Turn on @typescript-eslint/consistent-type-imports to ensure that all imports are correctly marked as type-only or runtime based on how they are used.

  • Turn on import/consistent-type-specifier to ensure that type imports are always separate from value imports.

  • Turn on import/no-duplicates.

  • Order type imports after the runtime imports from a module.

@tilgovi tilgovi requested review from smoores-dev and a team as code owners February 23, 2024 21:30
@tilgovi tilgovi force-pushed the clean-up-imports branch 4 times, most recently from 50e2635 to 62f26dd Compare February 23, 2024 23:26
- Turn on @typescript-eslint/consistent-type-imports to ensure that all
  imports are correctly marked as type-only or runtime based on how they
  are used.

- Turn on import/consistent-type-specifier to ensure that type imports
  are always separate from value imports.

- Turn on import/no-duplicates.

- Order type imports after the runtime imports from a module.
@tilgovi tilgovi merged commit 4c4adb6 into main Feb 24, 2024
2 checks passed
@tilgovi tilgovi deleted the clean-up-imports branch February 24, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants