Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass node view constructor arguments through to react node view constructors #23

Merged
merged 1 commit into from
Apr 26, 2023
Merged

Pass node view constructor arguments through to react node view constructors #23

merged 1 commit into from
Apr 26, 2023

Conversation

smoores-dev
Copy link
Collaborator

We want to enable consumers to:

  1. Make decisions about their dom and contentDOM elements based on their node and decorations
  2. Implement a custom update to tell ProseMirror to re-build a node view (and its dom and contentDOM`) when attributes that it cares about change

@smoores-dev smoores-dev requested a review from a team as a code owner April 26, 2023 19:04
@smoores-dev smoores-dev merged commit 0931a13 into main Apr 26, 2023
1 check passed
@smoores-dev smoores-dev deleted the node-view-constructor-arguments branch April 26, 2023 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tilgovi tilgovi tilgovi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@smoores-dev @tilgovi