fixes errors thrown when React unmounts the contentDOMWrapper #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tilgovi
reviewed
Nov 14, 2023
| // from the DOM. Here we attempt to reassemble the DOM that React | ||
| // expects when cleaning up the portal. | ||
| if (componentRef?.contentDOMParent) { | ||
| this.dom.appendChild(componentRef?.contentDOMParent); |
There was a problem hiding this comment.
nit: the ?. here shouldn't be necessary.
tilgovi
approved these changes
Nov 14, 2023
|
@saranrapjs you can resolve the version check issue with |
smoores-dev
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes a fix to #42 within the current architecture (where we create wrapping nodes and React portals for node views).
The inspiration for this approach comes from a previous implementation where we had to do something like what happens on this branch: at the moment that a NodeView's
destroyhook is being called, we re-attach the parts of the DOM which React controls in roughly the locations where React expects them for its cleanup phase.