Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for @track((props, [event]) => {}) signature #46

Closed
tizmagik opened this issue Sep 21, 2017 · 1 comment
Closed

Add test for @track((props, [event]) => {}) signature #46

tizmagik opened this issue Sep 21, 2017 · 1 comment

Comments

@tizmagik
Copy link
Collaborator

#45 revealed that we're missing a test for this use case/function signature mentioned in the docs

  // In this case the tracking data depends on
  // some unknown (until runtime) value
  @track((props, [event]) => ({ // NOTE: This PR would change this function signature
    action: 'click',
    label: event.currentTarget.title || event.currentTarget.textContent
  }))
  handleClick = (event) => {
    if (this.props.onClick) {
      this.props.onClick(event);
    }
  }
@tizmagik
Copy link
Collaborator Author

Done in #45

scentless-apprentice pushed a commit to scentless-apprentice/react-tracking that referenced this issue Apr 26, 2018
* Adding newsletter object to root

* Changing asset.collectionType to an array

* Fix for prettier validation

* Updating build files

* prettier update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant