Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for React 16.3 new Context API #67

Closed
tizmagik opened this issue Apr 3, 2018 · 3 comments · Fixed by #118
Closed

Support for React 16.3 new Context API #67

tizmagik opened this issue Apr 3, 2018 · 3 comments · Fixed by #118
Labels
enhancement help wanted

Comments

@tizmagik
Copy link
Collaborator

tizmagik commented Apr 3, 2018

Add (backwards-compatible) support for the new React 16.3 Context API, https://reactjs.org/blog/2018/03/29/react-v-16-3.html
lszm added a commit to lszm/react-tracking that referenced this issue May 25, 2018
@lszm
Support Ract 16 as a peer and dev dependency
613dd36 
This change moves the dev dependency from React 15.6, to React 16,
and adds React 16 as an accepted peer dependency. Comparing the differences
between 15.6 and 16 APIs, there are no breaking changes affecting React Tracking.

On the dev side Enzyme has been bumped to 3.x and setup to use its React 16 adapter.
There is also an added polyfill for requestAnimiationFrame support, which 16 relies on,
and which isn't available in the test environment.

This change does not address nytimes#67 at all,
but acts as a starting point to it.
lszm added a commit to lszm/react-tracking that referenced this issue May 25, 2018
@lszm
Support React 16 as a peer and dev dependency
408aade 
This change moves the dev dependency from React 15.6, to React 16,
and adds React 16 as an accepted peer dependency. Comparing the differences
between 15.6 and 16 APIs, there are no breaking changes affecting React Tracking.

On the dev side Enzyme has been bumped to 3.x and setup to use its React 16 adapter.
There is also an added polyfill for requestAnimiationFrame support, which 16 relies on,
and which isn't available in the test environment.

This change does not address nytimes#67 at all,
but acts as a starting point to it.
lszm added a commit to lszm/react-tracking that referenced this issue May 25, 2018
@lszm
Support React 16 as a peer and dev dependency
41c7342 
This change moves the dev dependency from React 15.6, to React 16,
and adds React 16 as an accepted peer dependency. Comparing the differences
between 15.6 and 16 APIs, there are no breaking changes affecting React Tracking.

On the dev side Enzyme has been bumped to 3.x and setup to use its React 16 adapter.
There is also an added polyfill for requestAnimiationFrame support, which 16 relies on,
and which isn't available in the test environment.

This change does not address nytimes#67 at all,
but acts as a starting point to it.
@lszm lszm mentioned this issue May 25, 2018
Merged
tizmagik pushed a commit that referenced this issue May 31, 2018
@lszm @tizmagik
Support React 16 as a peer and dev dependency (#72)
f3285b2 
* Support React 16 as a peer and dev dependency

This change moves the dev dependency from React 15.6, to React 16,
and adds React 16 as an accepted peer dependency. Comparing the differences
between 15.6 and 16 APIs, there are no breaking changes affecting React Tracking.

On the dev side Enzyme has been bumped to 3.x and setup to use its React 16 adapter.
There is also an added polyfill for requestAnimiationFrame support, which 16 relies on,
and which isn't available in the test environment.

This change does not address #67 at all,
but acts as a starting point to it.

* Address review feedback

- introduced Jest config file to setup enzyme and raf polyfill
- moved test setup file to root directory
- imported raf polyfill from npm
@garbles
Copy link

garbles commented Jun 22, 2018

Anyone pick this up yet?

@tizmagik
Copy link
Collaborator Author

@garbles nobody has yet, if you have time/interest please feel free! 🙏

@tizmagik tizmagik mentioned this issue Jun 28, 2018
Open
@tizmagik tizmagik mentioned this issue Aug 24, 2018
Closed
@tizmagik tizmagik mentioned this issue Mar 16, 2019
Merged
@tizmagik
Copy link
Collaborator Author

tizmagik commented Mar 16, 2019 •
edited
Loading

I published a version of react-tracking against the next tag as part of #118. If you have any time to test it out in your app, that'd be greatly appreciated! 🙏

npm install react-tracking@next

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

new context api nytimes/react-tracking
2 participants
@tizmagik @garbles