Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade babel dependencies + config to support core-js@3 #125

Merged
merged 3 commits into from May 20, 2019

Conversation

mckernanin
Copy link
Contributor

(likely a breaking change for core-js@2)

Fixes #119

@mckernanin
Copy link
Contributor Author

Build is failing because core-js isn't installed/updated. Not sure if there's something special that needs to happen to update the peer dependency, I'm not super familiar with them.

@mckernanin
Copy link
Contributor Author

Yep, adding it to the dependencies fixed the build. In master, core-js is in the lock file but not package.json. Is there a "right way" to do that, or just manually remove it from package.json?

@tizmagik
Copy link
Collaborator

I think having it as a peerDep is preferred in this case and then having it as a devDep would fix the build

@mckernanin
Copy link
Contributor Author

Ah ok. Bumping the branch shortly.

@tizmagik
Copy link
Collaborator

Thanks @mckernanin I think I'll lump this with #124 so that we don't have 2 breaking releases back to back.

@mckernanin
Copy link
Contributor Author

Sounds good, thanks!

@tizmagik tizmagik merged commit 16fecfd into nytimes:master May 20, 2019
@tizmagik
Copy link
Collaborator

Released as v7.0.0 🎉 Please holler (or open a new issue) if you see any problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Module not found: Error: Can't resolve 'core-js/modules/es6.function.bind
2 participants