remove core-js

[adi518]

This PR removes core-js (ES polyfills) and leaves it outside the bundle of this package. Consumers should now add polyfills to their app if they need to support old browsers. I wonder whether it should be released as a new major version, WDYT?

Other stuff this PR does:

• Bumps @babel/cli to latest minor (fixes some issues and adds --no-comments flag).
• Minify (--minified + --no-comments) which lowers the bundle size even more.
• Adds source-map generation (let me know if you want to keep it).

Next steps:
Use Webpack 5 or Rollup to build an ESM output, which will make this library treeshakeable, saving some more KBs for consumers. I suggest trying TSDX for this.

PS, Babel CLI docs aren't super updated, so better run yarn babel -h to see the latest options.

[tizmagik]

Do we also need a NODE_ENV=production ?

[adi518]

I don't think so, but I'll check.

[tizmagik]

Thanks, this is great! Do you mind also adding a note in the docs about the needed polyfills for older browser support moving forward after this change?

And yes, to answer your question, I think to be safe we will consider this a major breaking change.

[tizmagik]

Use Webpack 5 or Rollup to build an ESM output, which will make this library treeshakeable, saving some more KBs for consumers. I suggest trying TSDX for this.

Great idea. Happy to accept PRs for these as well (or at least an issue).

[adi518]

Sure, I'll update the readme.

[tizmagik]

Thanks! I might try and get a minor release out under v8 before merging this for a v9 release but approving and will hold for now 👍

[patrickskim]

core-js was an issue we've been having as well! Please merge & release ASAP!

[tizmagik]

Yes, looking to do a release this week hopefully. I want to land #168 as semver minor in v8 first

[tizmagik]

@patrickskim @adi518 looks like #168 might not land this week so I've published this PR against @alpha premajor release:

npm install react-tracking@9.0.0-0

Try it out and please post back with any issues you come across. Thanks!

[tizmagik]

@patrickskim @adi518 have you encountered any issues with this premajor?

[adi518]

I haven't pushed to production with the new version yet, but it's ongoing.

[antciccone]

@tizmagik We were able to upgrade to react-tracking@9.0.0-0 in our gatsby project. It has been pretty seamless so far. Will update you if @patrickskim or I run into any issues! Thanks for this work 🔥

[tizmagik]

v8.1.0 is released. I'll look to release a v9.0.0 next week or so with this change. Thanks again!

[adi518]

We are about two weeks in production with 9.0.0-0 and thus far, no issues.

[tizmagik]

RC v9.0.0-4 has been tagged, mind giving that a quick check and if all looks good I'll merge, tag and release this to mainline @adi518 @antciccone @patrickskim

npm install react-tracking@9.0.0-4

[gedeagas]

Removing core js make the bundle size much smaller. 15.3kb and 2.42 when gzip.

So far no issues, i will run the build on staging for a few days and wait the result.

Thank you for pushing this @tizmagik 🎉

[gedeagas]

@tizmagik after few days of dogfooding and thus far, no issues. I think this release is good to go.

🚢It 🎉

[tizmagik]

Great, thanks @gedeagas !

[tizmagik]

Hey @bgergen do you think we can get CI going again? I'd love to have it test this PR before we merge/publish, if possible

[bgergen]

@tizmagik Yes! I'll try to get that setup tomorrow. Sorry, I've been swamped today getting ready for Olympics coverage.

[bgergen]

@tizmagik Working on figuring out why this isn't triggering a drone build. Maybe I missed something in the config to get it to run on a PR from a fork.

[tizmagik]

Thanks @bgergen -- feel free to push directly to this branch

[tizmagik]

Yay thank you everyone for all the hard work! 🎉

[tizmagik]

This is now released as v9.0.0 thanks again all!