Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs for expanded useTracking API #171

Merged
merged 5 commits into from Nov 25, 2020
Merged

Conversation

bgergen
Copy link
Collaborator

@bgergen bgergen commented Nov 18, 2020

This updates the docs to account for the enhancements to the useTracking API introduced in 9c941ff

}
```

</details>
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tizmagik I can't tell whether these collapsible hook versions of the examples are useful. What do you think?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't hate them haha -- I actually think it might make sense to have the "old" decorator style be the collapsible example, but maybe for some future doc update. This is great for now, thanks!

Copy link
Collaborator

@tizmagik tizmagik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thank you! Some minor wordsmithing inline

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
}
```

</details>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't hate them haha -- I actually think it might make sense to have the "old" decorator style be the collapsible example, but maybe for some future doc update. This is great for now, thanks!

README.md Outdated Show resolved Hide resolved
@tizmagik tizmagik merged commit 4870609 into master Nov 25, 2020
@tizmagik tizmagik deleted the docs-hooks-update branch November 25, 2020 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants