Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to Github Actions #214

Merged
merged 4 commits into from
Jun 1, 2023
Merged

Switch to Github Actions #214

merged 4 commits into from
Jun 1, 2023

Conversation

tizmagik
Copy link
Collaborator

@tizmagik tizmagik commented Dec 18, 2022

Looks like open source Drone is no longer a thing...?

... and NYT doesn't allow GHA ... hmm

@bgergen
Copy link
Collaborator

bgergen commented Jan 4, 2023

Hmmm weird, I don't remember hearing anything about a change here. I can check in with folks to see what the recommended course of action is.

@bgergen
Copy link
Collaborator

bgergen commented Jan 24, 2023

@tizmagik Following up on this. Apparently there are major issues with Cloud Drone and DV is looking into alternatives (including GHA). I added myself as a watcher to their Jira ticket and there seem to be a number of other folks pressing them on this as well. I'll update here as soon as I hear more.

@tizmagik
Copy link
Collaborator Author

Great thanks for the update @bgergen !

@bgergen
Copy link
Collaborator

bgergen commented Feb 16, 2023

@tizmagik GitHub Actions are now supposedly enabled on this repo. Not sure how to test it though—maybe try pushing an empty commit to force the build to try to run again?

@bgergen
Copy link
Collaborator

bgergen commented Mar 3, 2023

@tizmagik Did it work? I'm not quite sure what I'm supposed to be seeing.

@tizmagik
Copy link
Collaborator Author

tizmagik commented Mar 3, 2023

Hmm, doesn't look like it's triggering? Will try and take a closer look at this when I get a chance.

@tizmagik
Copy link
Collaborator Author

GHA still don't seem to be triggering? Maybe we could try merging this PR and then open a new one against that? I wonder if the workflow needs to be in main for it to trigger? 🤷

@bgergen
Copy link
Collaborator

bgergen commented May 31, 2023

GHA still don't seem to be triggering? Maybe we could try merging this PR and then open a new one against that? I wonder if the workflow needs to be in main for it to trigger? 🤷

Ohhhh that could certainly be the case. I say go for it and let's see what happens—if it still doesn't work I can bug DV to take a look at at the repo and let us know what we're missing.

@tizmagik
Copy link
Collaborator Author

@bgergen ha! chatgpt found the bug 😂 faa372f

@tizmagik tizmagik requested a review from bgergen May 31, 2023 22:13
@bgergen
Copy link
Collaborator

bgergen commented May 31, 2023

omg

@tizmagik tizmagik merged commit 4d39ef8 into main Jun 1, 2023
3 checks passed
@tizmagik tizmagik deleted the jeremy/gha branch June 1, 2023 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants