What's the difference between 'nmt.py' in session 2 and session 3?

[amirj]

Unfortunately, following the difference in the source codes does not help me to solve the logical difference between 'nmt.py' in session 2 and session 3. Would you please describe the logical difference?

[orhanf]

@amirj nmt.py in session 2 and session 3 should be identical. Synched them here, can you check that please? If it works i can merge it with the central.

[amirj]

@orhanf I don't understand the relation between this link and the topic!
By the way, when I diff 'nmt.py' in session 2 and session 3 it seems that they are different to some extent. For example:

     shared_vars = [tparams[_p(prefix, 'U')],
                    tparams[_p(prefix, 'Wc')],
-                   tparams[_p(prefix, 'Wd_att')],
+                   tparams[_p(prefix, 'W_comb_att')],
                    tparams[_p(prefix, 'U_att')],
                    tparams[_p(prefix, 'c_tt')],
                    tparams[_p(prefix, 'Ux')],
-                   tparams[_p(prefix, 'Wcx')]]
+                   tparams[_p(prefix, 'Wcx')],
+                   tparams[_p(prefix, 'U_nl')],
+                   tparams[_p(prefix, 'Ux_nl')],
+                   tparams[_p(prefix, 'b_nl')],
+                   tparams[_p(prefix, 'bx_nl')]]

It seems that the attention mechanism has been changed in session3.

[orhanf]

lol, sorry my bad, i meant this. Actually it was session2 that has changed, and session3 is not adapted for those changes.

[amirj]

Is it means that learning with the current version of nmt.py in session3 leads to incorrect results?

On ۱ بهمن ۱۳۹۴ ه‍.ش., at ۲۰:۲۲, Orhan Firat notifications@github.com wrote:

lol, sorry my bad, i meant this orhanf@9199ac0. Actually it was session2 that has changed, and session3 is not adapted for those changes.

—
Reply to this email directly or view it on GitHub #29 (comment).

[orhanf]

Not incorrect results, actually the original version. Session2 implements an improved version tho.