Incorporate gru-nonlin #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -250,6 +250,39 @@ def param_init_gru(options, params, prefix='gru', nin=None, dim=None): | |||
| return params | |||
|
|
|||
|
|
|||
| def param_init_gru_nonlin(options, params, prefix='gru', | |||
There was a problem hiding this comment.
How about defining U_nl, b_nl, Ux_nl and bx_nl in param_init_gru_cond after calling param_init_gru, instead of making a new function param_init_gru_nonlin?
|
@jakezhaojb once the one comment I made is resolved, I'll merge it right away. |
|
Yes! I just did. Please review it. |
| nin=None, dim=None, dimctx=None): | ||
| nin=None, dim=None, dimctx=None, | ||
| nin_nonlin=None, dim_nonlin=None, | ||
| hiero_nonlin=False): |
There was a problem hiding this comment.
hiero_nonlin is not used in this code. Please remove any related entries.
|
Yeah done. |
|
Thanks, @jakezhaojb |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is basically an incorporation of the `nonlin' trick that introduced from [here].(https://github.com/laulysta/nmt). Please review before merging it into master.