Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add try-with-resources statement in CatVariantsMixin#onInitialize #29

Conversation

Steveplays28
Copy link
Contributor

No description provided.

@nyuppo nyuppo merged commit 2a0439a into nyuppo:master Apr 18, 2024
2 checks passed
@Steveplays28 Steveplays28 deleted the cat-entity-server-world-try-with-resources-statement branch April 18, 2024 20:42
@Steveplays28
Copy link
Contributor Author

Steveplays28 commented Apr 18, 2024

For anyone looking at this PR in the future: don't do this, use a cast instead: (ServerWorld) world.
This closes the ServerWorld after it's been used in one try block.

My bad on this one, nyuppo fixed this in commit b9b525e.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants