Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple gui for inspection #137

Merged
merged 15 commits into from
Nov 26, 2023
Merged

Conversation

ChristopherRabotin
Copy link
Member

@ChristopherRabotin ChristopherRabotin commented Nov 26, 2023

Summary

Add a GUI to inspect DAF SPK and BPC files.

Remaining work on this PR:

  • Build for Windows and publish artifact in Github CI
  • Build for Linux and publish artifact in Github CI
  • Build for MacOS and publish artifact in Github CI: not sure if this works, so I'm skipping it for now.
  • Inspect ANISE PCA files

Fixes #135

BPC

ANISE-BPC.webm

SPK

ANISE-SPK.webm

Architectural Changes

No change

New Features

No change to the core functionality. The GUI work is behind a feature gate.

Improvements

No change

Bug Fixes

No change

Testing and validation

Detail the changes in tests, including new tests and validations

Documentation

This PR does not primarily deal with documentation changes.

Copy link

codecov bot commented Nov 26, 2023

Codecov Report

Attention: 60 lines in your changes are missing coverage. Please review.

Comparison is base (bef51b3) 77.18% compared to head (c1f62aa) 76.93%.

Files Patch % Lines
src/almanac/mod.rs 42.85% 40 Missing ⚠️
src/structure/lookuptable.rs 6.25% 15 Missing ⚠️
src/bin/anise-cli/main.rs 0.00% 4 Missing ⚠️
src/naif/spk/summary.rs 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #137      +/-   ##
==========================================
- Coverage   77.18%   76.93%   -0.26%     
==========================================
  Files          67       67              
  Lines        7451     7595     +144     
==========================================
+ Hits         5751     5843      +92     
- Misses       1700     1752      +52     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChristopherRabotin ChristopherRabotin merged commit 5bc9fcc into master Nov 26, 2023
8 of 10 checks passed
@ChristopherRabotin ChristopherRabotin deleted the 135-simple-gui-for-inspection branch November 26, 2023 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simple GUI for inspection
1 participant