Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moon frame simplifications + add loading from MetaFile into Almanac #186

Merged
merged 6 commits into from
Jan 27, 2024

Conversation

ChristopherRabotin
Copy link
Member

Summary

Fixes #174 . Fixes #180 .

Architectural Changes

  • Stabilize ANISE semver in the kernels to version 0.3.0.

New Features

No change

Improvements

  • Add MOON_ME_FRAME and MOON_PA_FRAME

Bug Fixes

No change

Testing and validation

  • Add loading from MetaFile test

Documentation

  • Add documentation for ITRF93, IAU_EARTH, IAU_MOON, MOON_ME, MOON_PA frames.

There is only one Moon, and it's Earth's natural satellite.
+ Add ability to load MetaFile into Almanac directly
+ Add MOON_ME and MOON_PA frames
Copy link
Member Author

@ChristopherRabotin ChristopherRabotin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed, look good to me. Just adding codecov again

Copy link

codecov bot commented Jan 27, 2024

Codecov Report

Attention: 204 lines in your changes are missing coverage. Please review.

Comparison is base (89301ff) 77.14% compared to head (2c2ce28) 79.68%.
Report is 75 commits behind head on master.

Files Patch % Lines
anise/src/astro/utils.rs 36.56% 85 Missing ⚠️
anise/src/astro/aberration.rs 74.71% 22 Missing ⚠️
anise/src/almanac/aer.rs 92.48% 13 Missing ⚠️
anise/src/almanac/transform.rs 29.41% 12 Missing ⚠️
anise/src/almanac/metaload/metaalmanac.rs 86.90% 11 Missing ⚠️
anise/src/frames/frame.rs 21.42% 11 Missing ⚠️
anise/src/math/cartesian.rs 71.79% 11 Missing ⚠️
anise/src/naif/pretty_print.rs 87.69% 8 Missing ⚠️
anise/src/ephemerides/translations.rs 92.78% 7 Missing ⚠️
anise/src/almanac/metaload/mod.rs 92.30% 5 Missing ⚠️
... and 8 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #186      +/-   ##
==========================================
+ Coverage   77.14%   79.68%   +2.53%     
==========================================
  Files          67       70       +3     
  Lines        7815     8506     +691     
==========================================
+ Hits         6029     6778     +749     
+ Misses       1786     1728      -58     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChristopherRabotin ChristopherRabotin merged commit f413f5f into master Jan 27, 2024
21 checks passed
@ChristopherRabotin ChristopherRabotin deleted the 174-moon-frame-simplifications branch May 31, 2024 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow loading from MetaFile Moon frame simplifications
1 participant