Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sun observer angle calculation (or solar probe angle) #188

Merged
merged 4 commits into from
Jan 29, 2024

Conversation

ChristopherRabotin
Copy link
Member

Summary

New feature: computation of the sun angle between an observer (e.g. a probe) and another celestial object (e.g. the primary body that probe orbits). This allows the computation of the Sun-probe-Earth angle, for example, if the observer is the probe and the target is the primary body it orbits.

Architectural Changes

No change

New Features

  • Add sun_angle_deg and sun_angle_deg_from_frames function signatures

Improvements

No change

Bug Fixes

No change

Testing and validation

  • Test that with the gmat-hermite.bsp file, which contains ~ 3 hours of Earth centered propagation, the computation of the SPE is (almost) exactly 90 degrees greater than the Sun elevation at the point exactly nadir of the spacecraft at a geodetic height of zero kilometers. An error of 0.05 degrees is acceptable because the SPE does not account for the flattening of the Earth but the elevation does since it's computed from the latitude and longitude in the IAU Earth frame, which accounts for that flattening ratio.

Documentation

This PR does not primarily deal with documentation changes.

Copy link

codecov bot commented Jan 27, 2024

Codecov Report

Attention: 21 lines in your changes are missing coverage. Please review.

Comparison is base (f413f5f) 79.68% compared to head (5591b2c) 80.14%.

Files Patch % Lines
anise/src/almanac/bpc.rs 38.70% 19 Missing ⚠️
anise/src/naif/spk/summary.rs 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #188      +/-   ##
==========================================
+ Coverage   79.68%   80.14%   +0.46%     
==========================================
  Files          70       71       +1     
  Lines        8506     8653     +147     
==========================================
+ Hits         6778     6935     +157     
+ Misses       1728     1718      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChristopherRabotin ChristopherRabotin merged commit 6d38c4b into master Jan 29, 2024
22 checks passed
@ChristopherRabotin ChristopherRabotin deleted the 187-solar-observer-angle-calculation branch January 29, 2024 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
algo Related to the core ANISE algorithms Kind: new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant