Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duration serde now human readable + Display of Epoch is now Gregorian in its initialization time scale #299

Merged

Conversation

ChristopherRabotin
Copy link
Member

@ChristopherRabotin ChristopherRabotin commented Apr 25, 2024

Fixes #231 and #217 .

Only merge after additional regression tests (and potential fixes) for #292 have been added. Moved to #255

@@ -929,38 +929,6 @@ fn test_from_str() {
);
}

// #[test]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gwbres I've removed this test because I still don't understand it (and I had commented it out in #289).

@ChristopherRabotin ChristopherRabotin merged commit f9d4100 into master Apr 26, 2024
29 checks passed
@ChristopherRabotin ChristopherRabotin deleted the 217-duration-and-epoch-serde-to-be-human-readable branch April 26, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display should print in Gregorian in the Epoch's time scale
1 participant