Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add online measurement rejection #145

Merged
merged 5 commits into from
May 12, 2023

Conversation

ChristopherRabotin
Copy link
Member

@ChristopherRabotin ChristopherRabotin commented May 12, 2023

Effects

Add the ability to reject measurements online prior to ingesting them in the filter. When rejected, a warning is printed and the filter performs a time update instead.

If this is a new feature or a bug fix ...

  • Yes, the branch I'm proposing to merge is called issue-xyz where xyz is the number of the issue.

If this change adds or modifies a validation case

  • No.

TODO:

  • Add test of rejection
  • Add ability to configure via Python (can be configured in YAML but not used in Python yet -- should be a path to a YAML file)

Closes #127

Signed-off-by: Christopher Rabotin <christopher.rabotin@gmail.com>
@codecov
Copy link

codecov bot commented May 12, 2023

Codecov Report

Patch coverage: 62.12% and project coverage change: +0.29 🎉

Comparison is base (c4c3188) 29.15% compared to head (636c61b) 29.45%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #145      +/-   ##
==========================================
+ Coverage   29.15%   29.45%   +0.29%     
==========================================
  Files         126      128       +2     
  Lines       33301    33251      -50     
==========================================
+ Hits         9710     9795      +85     
+ Misses      23591    23456     -135     
Impacted Files Coverage Δ
src/od/mod.rs 0.00% <ø> (ø)
tests/orbit_determination/mod.rs 0.00% <0.00%> (ø)
tests/orbit_determination/multi_body.rs 0.00% <0.00%> (ø)
tests/orbit_determination/spacecraft.rs 0.00% <0.00%> (ø)
tests/orbit_determination/two_body.rs 0.00% <0.00%> (ø)
tests/orbit_determination/xhat_dev.rs 0.00% <0.00%> (ø)
src/od/process/rejectcrit.rs 37.50% <37.50%> (ø)
src/od/residual.rs 31.25% <51.61%> (+16.96%) ⬆️
src/od/process/mod.rs 67.83% <87.87%> (+5.20%) ⬆️
src/od/kalman.rs 77.34% <94.11%> (+0.54%) ⬆️
... and 2 more

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Christopher Rabotin <christopher.rabotin@gmail.com>
Signed-off-by: Christopher Rabotin <christopher.rabotin@gmail.com>
Signed-off-by: Christopher Rabotin <christopher.rabotin@gmail.com>
Signed-off-by: Christopher Rabotin <christopher.rabotin@gmail.com>
@ChristopherRabotin ChristopherRabotin merged commit bae4921 into master May 12, 2023
21 checks passed
@ChristopherRabotin ChristopherRabotin deleted the 127-online-measurement-rejection branch May 12, 2023 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Online measurement rejection
1 participant