Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for WASM targets #153

Merged
merged 5 commits into from
May 24, 2023
Merged

Add support for WASM targets #153

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6d63af8
Add build step to verify that WASM build is working
thomasantony May 24, 2023
35f3e8f
Update dependencies to allow building for WASM targets
thomasantony May 24, 2023
a30c7d6
Merge branch 'master' into feature/build_for_wasm_target
ChristopherRabotin May 24, 2023
9c58f4d
Update Cargo.toml
ChristopherRabotin May 24, 2023
9e98272
Update Cargo.toml to add brotli feature to parquet
ChristopherRabotin May 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,14 @@ jobs:
uses: dtolnay/rust-toolchain@master
with:
toolchain: stable
targets: wasm32-unknown-unknown

- name: Run cargo check
run: cargo check

- name: Run cargo check for WASM target
run: cargo check --target wasm32-unknown-unknown

tests:
strategy:
matrix:
Expand Down
5 changes: 3 additions & 2 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,14 +46,15 @@ numpy = {version = "0.17", optional = true}
indicatif = {version = "0.17", features = ["rayon"]}
rstats = "1.2.50"
thiserror = "1.0"
parquet = "40.0.0"
parquet = {version = "40.0.0", default-features = false, features = ["arrow", "brotli"]}
arrow = "40.0.0"
shadow-rs = "0.21.0"
shadow-rs = {version = "0.21.0", default-features = false}
serde_yaml = "0.9.21"
whoami = "1.3.0"
either = {version = "1.8.1", features = ["serde"]}
num = "0.4.0"
enum-iterator = "1.4.0"
getrandom = {version = "0.2", features = ["js"]}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What functionality does the getrandom crate add?

Copy link
Contributor Author

@thomasantony thomasantony May 25, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is used by the rand crate (which is a direct dependency of nyx). If we do not specify this feature flag, it cannot be compiled for WASM.


[dev-dependencies]
polars = {version = "0.29.0", features = ["parquet"]}
Expand Down
Loading