(feat) refactor are_eigenvalues_stable
#178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #178 +/- ##
==========================================
+ Coverage 66.33% 66.51% +0.17%
==========================================
Files 127 127
Lines 32445 32458 +13
==========================================
+ Hits 21524 21589 +65
+ Misses 10921 10869 -52
☔ View full report in Codecov by Sentry. |
| continue; | ||
| } | ||
| } | ||
| eigenvalues.iter().all(|ev| ev.re <= 0.0) |
There was a problem hiding this comment.
Haha yup, that's infinitely simpler than the previous code and mathematically the same, thanks!
ChristopherRabotin
approved these changes
Jun 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following is a revised version of the
are_eigenvalues_stablefunction with improved documentation, a clearer code structure and unit tests.