Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase tolerance on xhat dev test #265

Merged
merged 1 commit into from
Dec 23, 2023

Conversation

ChristopherRabotin
Copy link
Member

Effects

All the tests to pass on Github Actions.

If this change adds or modifies a validation case

  • Yes: The initial state deviation 16.45 km off and after the OD (without any IOD or iteration), it's down to < 200 m on my machine but it's 330 m on Github action. I increased the acceptable error in this test. Initial orbit determination #84 will add IOD options, and Add least squares batch filter #85 will add a faster converging iteration OD method, so these will reduce these kinds of errors further.

Copy link

Visit the preview URL for this PR (updated for commit 5a519b2):

https://nyx-rustdoc--pr265-hotfix-xhat-dev-harm-hvlh3tr7.web.app

(expires Sat, 30 Dec 2023 23:37:04 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: d8e2a55934352d850c15d11866c39eb2d2e029be

@ChristopherRabotin ChristopherRabotin merged commit e29c24d into master Dec 23, 2023
12 checks passed
@ChristopherRabotin ChristopherRabotin deleted the hotfix/xhat_dev_harmonics_fix branch December 23, 2023 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant