Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why masternodes for onion-network (without "normal" public ip) are blocked? #6

Open
cryptocoinguru opened this issue Feb 17, 2021 · 1 comment

Comments

@cryptocoinguru
Copy link

Why masternodes for onion-network only blocked? I noticed some other coins/masternodes like dash, pivx and so on explicitly allow using TOR-Network only masternodes.

  1. https://github.com/PIVX-Project/PIVX/blob/master/doc/tor.md
  2. https://github.com/dashpay/dash/blob/master/doc/tor.md

NYX seems basically to implement (fork?) the same features used there. But any non IPv4 and IPv6 address (like Onion-Address) is blocked and giving "Masternode not capable" or "Invalid IP Address".

Is this a desired limitation or a side-effect of the IP Address validation in the code:

  1. bool fFoundLocal = GetLocal(service) && CMasternode::IsValidNetAddr(service);
  2. bool CMasternode::IsValidNetAddr(CService addrIn)
@cryptocoinguru
Copy link
Author

cryptocoinguru commented Feb 17, 2021

I think this is the corresponding PIVX change that allows address validation for onion-masternodes:
PIVX-Project/PIVX@de45ddc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant