Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add avatar decorations to cdn endpoints #410

Merged
merged 1 commit into from
Dec 9, 2022
Merged

Add avatar decorations to cdn endpoints #410

merged 1 commit into from
Dec 9, 2022

Conversation

Rapougnac
Copy link
Member

Description

Add support for avatar decorations

Connected issues & other potential problems

Relevant:

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • Ran dart analyze or make analyze and fixed all issues
  • Ran dart format --set-exit-if-changed -l 160 ./lib or make format and fixed all issues
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my changes haven't lowered code coverage

abitofevrything
abitofevrything approved these changes Dec 9, 2022
View reviewed changes
Copy link
Member

@abitofevrything abitofevrything left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will merge once the associated PR on the Discord API docs is merged.

@l7ssha l7ssha added the enhancement New feature or request label Dec 9, 2022
@l7ssha l7ssha added this to the 4.4 milestone Dec 9, 2022
@Rapougnac Rapougnac self-assigned this Dec 9, 2022
@l7ssha l7ssha merged commit e9256a4 into next Dec 9, 2022
@l7ssha l7ssha deleted the feat/cdn-avatars-decorations branch December 9, 2022 18:02
@l7ssha l7ssha modified the milestones: 4.4, 5.0 Dec 9, 2022
@l7ssha l7ssha linked an issue Jan 6, 2023 that may be closed by this pull request
feature: Implement avatar decorations #417
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@l7ssha l7ssha l7ssha approved these changes

@abitofevrything abitofevrything abitofevrything approved these changes

Assignees

@Rapougnac Rapougnac

Labels
enhancement New feature or request
Projects
nyxx roadmap
Status: Done
Milestone
5.0
Development

Successfully merging this pull request may close these issues.

feature: Implement avatar decorations
3 participants
@Rapougnac @l7ssha @abitofevrything