Fixing setPresence method #69
Conversation
nyxx/lib/src/Shard.dart
Outdated
| 'type' : game.type, | ||
| if(game.type == ActivityType.streaming) 'url' : game.url | ||
| 'type' : game.type._value, | ||
| if(game.type._value == ActivityType.streaming._value) 'url' : game.url |
There was a problem hiding this comment.
Can you remove _value and modify == operator in ActivityType
other is ActivityType && other._value == this._valueThere was a problem hiding this comment.
Should I also remove it for the moment in 'type' : game.type._value? The only workaround I can think of that would leave it in a usable state would be to parse an int from the toString of game.type ultimately looking like:
'type' : int.parse(game.type.toString())Although this would most likely be changed when getters are made for the enums if it's remembered
There was a problem hiding this comment.
In that case not because we need int as in documentation. This is related to #70 that we need sometimes raw value of enum and now we don't have way to.
|
All "enums" should probably have something like |
Fixing setPresence method [ci skip]
Resolves both a serialization error to json & an issue regarding the packet format that discord expects for the presence.