Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Par-renamer and par-files with obfuscated base names #313

Closed
hugbug opened this issue Dec 4, 2016 · 0 comments

Comments

@hugbug
Copy link
Member

commented Dec 4, 2016

Par-renamer automatically restores original names for obfuscated files using par-files. If download doesn't have files with par-extensions the renamer checks content of all files detecting renamed par-files and then restores par-extensions. When doing so it also correctly group par-files into par-sets giving them the same base name.

There is one special case which par-renamer doesn't handle at the moment. If download contains par-files with par-extensions but with changed (obfuscated) different base names the renamer doesn't rename those files. Moreover such par-files are processed as separate par-sets (they have different base names and look as different par-sets).

That causes par-renamer to falsely detect missing files and initiate par-check to repair download. The par-check then has its own problems with renamed par-files. It finds different par-sets and processes each par-set separately. As a result the download is par-checked multiple times.

Thanks to quick par-verification the par-check usually takes not so long but the par-renamer can be improved nonetheless in two ways:

  • avoid false detection of missing files;
  • rename par-files (even those having par-extension) to build correct par-sets.

As a result of this improvement the downloads having obfuscated par-files will not be par-checked if no errors occurred and if repair is needed the par-check will be performed only once.

@hugbug hugbug added the improvement label Dec 4, 2016

@hugbug hugbug added this to the v18 milestone Dec 4, 2016

hugbug added a commit that referenced this issue Dec 4, 2016
#313: better handling of obfuscated par-files in par-renamer
Avoid false detection of missing files.
hugbug added a commit that referenced this issue Dec 6, 2016

@hugbug hugbug closed this Dec 6, 2016

hugbug added a commit that referenced this issue Dec 6, 2016
hugbug added a commit that referenced this issue Oct 9, 2017
#313: better handling of obfuscated par-files in par-renamer
Avoid false detection of missing files.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.