Skip to content
This repository has been archived by the owner on Nov 18, 2022. It is now read-only.

TLS/SSL certificate verification #339

Closed
9 tasks done
hugbug opened this issue Feb 14, 2017 · 0 comments
Closed
9 tasks done

TLS/SSL certificate verification #339

hugbug opened this issue Feb 14, 2017 · 0 comments
Labels
Milestone

Comments

@hugbug
Copy link
Member

hugbug commented Feb 14, 2017

NZBGet supports TLS/SSL for communication with news and web servers. Connections are encrypted but the implementation lacks an important step - server certificate verification. As a result the security is reduced, in particular undetectable Man-in-the-Middle attacks (MitM) are possible.

Further details can be found in discussion #332.

To improve security NZBGet should implement server certificate verification, including hostname validation.

NZBGet can be compiled with either OpenSSL or GnuTLS. Since these two libraries have different API the certificate verification in NZBGet requires two implementations.

Tasks:

  • general certificate verification when compiling with OpenSSL;
  • hostname verification when compiling with OpenSSL;
  • general certificate verification when compiling with GnuTLS;
  • hostname verification when compiling with GnuTLS;
  • integrate root certificate store file into Windows installer;
  • integrate root certificate store file into OSX installer;
  • integrate root certificate store file into Linux/FreeBSD installer;
  • optional: automatic refresh of root certificate store file during setup build;
  • write wiki page about how to deal with verification errors.
@hugbug hugbug added the feature label Feb 14, 2017
@hugbug hugbug added this to the v19 milestone Feb 14, 2017
hugbug added a commit that referenced this issue Feb 17, 2017
@hugbug hugbug closed this as completed Feb 20, 2017
hugbug added a commit to nzbget/nzbget.github.io that referenced this issue Jul 2, 2017
hugbug added a commit that referenced this issue Oct 9, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant