Skip to content
This repository has been archived by the owner on Nov 18, 2022. It is now read-only.

Unnecessary requests to news servers #360

Closed
hugbug opened this issue Apr 14, 2017 · 0 comments
Closed

Unnecessary requests to news servers #360

hugbug opened this issue Apr 14, 2017 · 0 comments
Milestone

Comments

@hugbug
Copy link
Member

hugbug commented Apr 14, 2017

When requesting articles from news servers NZBGet retries three times. The extra attempts are made to cope with badly behaving news servers that may return an error code on first attempt and then a success on a second or third attempt.

This code was OK years ago but nowadays it makes more harm than good. For DMCA'ed articles that means that each article is requested three times effectively tripling the time needed for an unhealthy download to fail.

In this issue: remove extra retries and request each article only once.

Note: these three attempts are not related to option ArticleRetries, which controls attempts for download errors or crc errors but not for response codes on article requests.

@hugbug hugbug added this to the v19 milestone Apr 14, 2017
@hugbug hugbug changed the title Unnecessary download attempts Unnecessary requests to news servers Apr 14, 2017
@hugbug hugbug closed this as completed Apr 14, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant