Skip to content
This repository has been archived by the owner on Nov 18, 2022. It is now read-only.

Unpack during downloading #371

Closed
8 tasks done
hugbug opened this issue May 3, 2017 · 4 comments
Closed
8 tasks done

Unpack during downloading #371

hugbug opened this issue May 3, 2017 · 4 comments
Labels
Milestone

Comments

@hugbug
Copy link
Member

hugbug commented May 3, 2017

Currently downloading and unpacking are separate stages. The unpack starts after the nzb is completely downloaded. To better use computer resources NZBGet can download one item and post-process another item at the same time.

However if a certain nzb is needed quickly the total process could take less time if unpack would start as soon as first archive part is downloaded and continue as long as new parts come in.

This issue is to experiment with unpack during downloading feature.

The prerequisites to this feature are:

Unpack during downloading can obviously work only for healthy downloads. Therefore it is not intended to replace default unpack module.

Task list:

  • extend script controller with stdin redirecting;
  • create new module to do direct unpack;
  • handle unrar stdin to emulate user input in regard to handling of multi disk messages;
  • integrate direct unpack module into post-processing workflow;
  • cancel direct unpack on: program reload, deleting nzb, unpack errors;
  • support downloads with multiple independent archives;
  • restart direct unpack after program reload;
  • detect not unpacked archives which may appear after rar-rename and unpack them during post-processing.
@hugbug hugbug added the feature label May 3, 2017
hugbug added a commit that referenced this issue May 5, 2017
without implementation.
hugbug added a commit that referenced this issue May 5, 2017
without implementation and with a new failing unit test.
hugbug added a commit that referenced this issue May 5, 2017
hugbug added a commit that referenced this issue May 5, 2017
Archive parts are now unpacked as they arrive.
hugbug added a commit that referenced this issue May 5, 2017
because it misses unrar 5 required for the tests
@wtf911
Copy link
Contributor

wtf911 commented May 7, 2017

How is the progress coming along? :) I see you've made a new branch.

@hugbug
Copy link
Member Author

hugbug commented May 7, 2017

It's working. There are few things to do left but you can already try it and tell me how well it works for you. Make sure to enable DirectRename and ReorderFiles (in addition to DirectUnpack).

To test use branch 371-direct-unpack.

@hugbug
Copy link
Member Author

hugbug commented May 7, 2017

Updated the first post with a task list for you to follow the progress.

@hugbug hugbug added this to the v19 milestone May 7, 2017
@wtf911
Copy link
Contributor

wtf911 commented May 8, 2017

Thank you. :)

hugbug added a commit that referenced this issue May 8, 2017
When program is reloaded during direct unpack the unpack restarts after
one (any) inner file is downloaded.
hugbug added a commit that referenced this issue May 12, 2017
Detect not unpacked archives which may appear after rar-rename and
unpack them during post-processing.
@hugbug hugbug closed this as completed May 12, 2017
hugbug added a commit that referenced this issue May 18, 2017
Deleting destination if it contains only hidden files.
hugbug added a commit that referenced this issue May 23, 2017
hugbug added a commit that referenced this issue May 31, 2017
hugbug added a commit that referenced this issue Jun 6, 2017
to avoid running way too many direct unpack jobs at the same time.
hugbug added a commit that referenced this issue Jun 16, 2017
hugbug added a commit that referenced this issue Oct 9, 2017
without implementation.
hugbug added a commit that referenced this issue Oct 9, 2017
without implementation and with a new failing unit test.
hugbug added a commit that referenced this issue Oct 9, 2017
hugbug added a commit that referenced this issue Oct 9, 2017
Archive parts are now unpacked as they arrive.
hugbug added a commit that referenced this issue Oct 9, 2017
because it misses unrar 5 required for the tests
hugbug added a commit that referenced this issue Oct 9, 2017
When program is reloaded during direct unpack the unpack restarts after
one (any) inner file is downloaded.
hugbug added a commit that referenced this issue Oct 9, 2017
Detect not unpacked archives which may appear after rar-rename and
unpack them during post-processing.
hugbug added a commit that referenced this issue Oct 9, 2017
Deleting destination if it contains only hidden files.
hugbug added a commit that referenced this issue Oct 9, 2017
hugbug added a commit that referenced this issue Oct 9, 2017
hugbug added a commit that referenced this issue Oct 9, 2017
to avoid running way too many direct unpack jobs at the same time.
hugbug added a commit that referenced this issue Oct 9, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants