Fix: possible memory corruption (#148)

- fixed possible memory corruption inspired by reports from nzbget-ng
nzbgetcom · Jan 26, 2024 · 16ab25d · 16ab25d
1 parent 8515370
commit 16ab25d
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/daemon/util/NString.cpp b/daemon/util/NString.cpp
@@ -155,7 +155,14 @@ void CString::AppendFmtV(const char* format, va_list ap)
 
 	int curLen = Length();
 	int newLen = curLen + addLen;
-	m_data = (char*)realloc(m_data, newLen + 1);
+
+	char* newData = (char*)realloc(m_data, newLen + 1);
+	if (newData == nullptr) 
+	{
+		return;
+	}
+
+	m_data = newData;
 
 	vsnprintf(m_data + curLen, newLen + 1, format, ap2);
 

diff --git a/lib/par2/reedsolomon.h b/lib/par2/reedsolomon.h
@@ -122,7 +122,7 @@ inline ReedSolomon<g>::ReedSolomon(std::ostream& cout, std::ostream& cerr) :
   datamissingindex = 0;
   database = 0;
 
-  outputrows.empty();
+  outputrows.clear();
 
   outputcount = 0;