Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't have two different dot-pulse colors with Sass #14

Closed
pszalko opened this issue May 6, 2021 · 2 comments
Closed

Can't have two different dot-pulse colors with Sass #14

pszalko opened this issue May 6, 2021 · 2 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@pszalko
Copy link
Contributor

pszalko commented May 6, 2021

My use case is to have two different colors of dot-pulse animation on the same page when extending Sass modules.
For example: I use white dot-pulse on dark background and blue dot-pulse on white.

The following code does not work:

.dot-primary-sm {
    $dot-width: 2px;
    $dot-height: 2px;
    $dot-spacing: 6px;
    $dot-color: $trgl-brand-color;

    @import '~three-dots/sass/three-dots';
}

.dot-white-sm {
    $dot-width: 2px;
    $dot-height: 2px;
    $dot-spacing: 6px;
    $dot-color: $white;

    @import '~three-dots/sass/three-dots';
}

I suppose the issue is caused by box-shadow property that overrides color in keyframe animation.

@pszalko
Copy link
Contributor Author

pszalko commented May 6, 2021

@nzbin Please merge and release new version if possible :)

@nzbin nzbin added bug Something isn't working good first issue Good for newcomers labels May 7, 2021
@nzbin
Copy link
Owner

nzbin commented May 7, 2021

Many thanks. v0.2.1 has released.

@nzbin nzbin closed this as completed May 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants