Ai microrevamp #31
Ai microrevamp #31
Conversation
Includes various optimizations and bugfixes
Fix function names Fix `n_waypoints` calc Misc cleanups
Removed redundant "id" / "target_id" waypoint fields Update beta-map waypoint loading code to use waypoint "owners" rather than "links"
|
Tested maps f4ll, nacht, house. pathfinding behavior seems significantly improved |
| int openset[MAX_WAYPOINTS];//Actual sorted open list | ||
| int opensetRef[MAX_WAYPOINTS];//Reference values of open list | ||
| int opensetLength;//equivalent of javaScript's array[].length; | ||
|
|
||
| #define MaxZombies 16 |
There was a problem hiding this comment.
Is this used? If so, what is this for?
There was a problem hiding this comment.
It's used to allocate memory to stash a path per-zombie as a list of waypoints.
|
|
||
| char waypoint_set[MAX_WAYPOINTS]; // waypoint_set[i] contains the set identifier for the i-th waypoint | ||
| unsigned short openset_waypoints[MAX_WAYPOINTS]; // List of waypoints currently in the open set sorted by heuristic cost (index 0 contains lowest cost waypoint) | ||
| unsigned short openset_length; // Current length of the open set | ||
| zombie_ai zombie_list[MaxZombies]; |
There was a problem hiding this comment.
We should use the same value returned by the PF_maxai builtin.
There was a problem hiding this comment.
Looks like nzp_maxai maps to void PF_MaxZombies(void) which has a hardcoded 12
I partly think we should rename things to be zombie-agnostic (for other AI types), but navmeshes will eventually replace it all.
I think for now the best move might be to update PF_MaxZombies to instead return this MaxZombies preprocessor define.
There was a problem hiding this comment.
Sure. To clarify, my concern was the disparity between these numbers. If we can change this macro to 12 and have this builtin return this macro as well, that is perfectly fine.
| void sv_way_print_sorted_open_set() { | ||
| Con_Printf("Sorted open-set F-scores: "); | ||
| for(int i = 0; i < openset_length; i++) { | ||
| Con_Printf("%.0f, ",waypoints[openset_waypoints[i]].f_score); | ||
| } | ||
| Con_Printf("\n"); | ||
| } |
There was a problem hiding this comment.
Can you make these Con_Dprintfs instead?
| } | ||
|
|
||
| if(n_openset_waypoints != openset_length) { | ||
| Con_Printf("%i%i%i\n", n_openset_waypoints, openset_length); |
Starting conversation here to get these fixes merged into prod.
Testing on hardware / emu still pending, will report back once testing's done.