Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regenerate ids on blueprint #167

Merged
merged 6 commits into from Oct 3, 2018
Merged

Conversation

benib
Copy link
Contributor

@benib benib commented Oct 3, 2018

  • fixes regenerate generateId properties on items on blueprint #62
  • this refactors the blueprinting like this:
    • do not just copy the data and changing some properties
    • instead generate a new object based on the tools schema
    • all properties that are available on the original object but not defined in the schema will be removed
    • any property that has generatedId as the Q:default will be regenerated based on the new id

This can be tested with our quiz tool (the id of the single questions needs to be regenerated on blueprinting based on the new id).

@benib benib requested a review from manuelroth October 3, 2018 10:04
@benib benib merged commit 7a57f36 into dev Oct 3, 2018
@benib benib deleted the fix-regenerate-ids-on-blueprint branch October 3, 2018 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

regenerate generateId properties on items on blueprint
2 participants