Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git: Only add diffs to .rs files #32

Closed
o0Ignition0o opened this issue Dec 4, 2019 · 3 comments
Closed

git: Only add diffs to .rs files #32

o0Ignition0o opened this issue Dec 4, 2019 · 3 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@o0Ignition0o
Copy link
Owner

o0Ignition0o commented Dec 4, 2019

Right now we add any file that has a diff to the list.
We should only add rust files to the list because it will later allow us to run clippy only when needed (and on needed workspace members).

Maybe we could add a continue statement if the file_name doesn't end with .rs ?
https://github.com/o0Ignition0o/cargo-scout/blob/master/src/git.rs#L91

It would be really awesome if we could add a test to it :)

@o0Ignition0o o0Ignition0o added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Dec 4, 2019
@oScape
Copy link
Contributor

oScape commented Dec 5, 2019

Hi @o0Ignition0o, I will take it if possible :)

@o0Ignition0o
Copy link
Owner Author

Hi @oScape and thank you for grabbing it ! :)

If you have any questions please let me know, I will gladly spend some time with you and walk through the issue :)

@ebroto
Copy link
Contributor

ebroto commented Dec 14, 2019

I think this one can be closed since #39 was merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants