Only add diffs to .rs files #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
o0Ignition0o
approved these changes
Dec 11, 2019
| @@ -239,4 +242,22 @@ mod tests { | |||
| // Assert | |||
| assert_eq!(expected_sections, actual_sections); | |||
| } | |||
| #[test] | |||
| fn test_diff_several_extensions_files() { | |||
There was a problem hiding this comment.
Really happy to see we have a new test !
As a followup maybe we could add an example with a .rs file and a non .rs file in the same diff ?
There was a problem hiding this comment.
I already add a test with a .rs and a .yml file, I think we can improve the test by adding a multi diff on the same .rs file for covering it all.
There was a problem hiding this comment.
Yeah I actually meant that.
We can do it in a followup PR though, it's pretty fine already :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regarding #32, I add a check on the
Parserfor add only the.rsfiles and avoid the others.Includes test functionality.