Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a test for multidiff with several extensions #40

Open
o0Ignition0o opened this issue Dec 11, 2019 · 5 comments
Open

Add a test for multidiff with several extensions #40

o0Ignition0o opened this issue Dec 11, 2019 · 5 comments
Assignees

Comments

@o0Ignition0o
Copy link
Owner

o0Ignition0o commented Dec 11, 2019

As a followup to #39 and as explained here It would be nice to add a test with a diff containing several changes to a .rs file and one or more changes to an other file extension.

@o0Ignition0o o0Ignition0o changed the title Add a test for extensions Add a test for multidiff with several extensions Dec 11, 2019
@oScape
Copy link
Contributor

oScape commented Dec 11, 2019

As I implemented it with the PR #39 I can improve it if you want.

@o0Ignition0o
Copy link
Owner Author

Sure, go ahead ! thanks for working on it :D

@ebroto
Copy link
Contributor

ebroto commented Dec 14, 2019

Hey @oScape! just a heads-up that there have been a couple changes to the code. There's already a test with serveral extensions but it's only covering newly added files. I think we could add another test for modified files (so files already commited to the repo with changes in the working tree).

Let me know what you think!

@oScape
Copy link
Contributor

oScape commented Dec 16, 2019

Hey @ebroto, I will check it asap, and add the test for midifed files.

@o0Ignition0o
Copy link
Owner Author

Take your time, there’s no rush :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants