Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce limits on # of parties, events, & sequence events to match those defined by the protocol #276

Closed
jasongitmail opened this issue Jul 11, 2022 · 8 comments · Fixed by #620
Assignees

Comments

@jasongitmail
Copy link
Contributor

jasongitmail commented Jul 11, 2022

No description provided.

@jasongitmail
Copy link
Contributor Author

Ideally we throw a compile time error

@jasongitmail jasongitmail changed the title Implement limits on events that are enforced at the protocol level Implement limits on parties, events, & sequence events that are enforced at the protocol level Aug 1, 2022
@jasongitmail jasongitmail changed the title Implement limits on parties, events, & sequence events that are enforced at the protocol level Enforce limits on # of parties, events, & sequence events to match those defined by the protocol Aug 1, 2022
@Comdex
Copy link
Contributor

Comdex commented Sep 7, 2022

Hey! I don't know whether it is appropriate to ask here, because I only found this relevant open issue. How many fields is the limit size of each event and sequence event? And what is the total limit size of events and sequence events in each transaction?

@mitschabaude
Copy link
Member

there's no extra limit for the number of fields in one (sequence) event, but there'll be a limit on the total number of all fields in all events / sequence events. We're still in the process of deciding the exact number, but it'll be about ~20-30 I think

@Comdex
Copy link
Contributor

Comdex commented Sep 7, 2022

there's no extra limit for the number of fields in one (sequence) event, but there'll be a limit on the total number of all fields in all events / sequence events. We're still in the process of deciding the exact number, but it'll be about ~20-30 I think

Personally, I prefer this limit >= 30, which I think would be more friendly to some privacy use cases based on the UTXO model, such as coin mixers.

@mitschabaude
Copy link
Member

mitschabaude commented Sep 7, 2022

Most of these limits will be fairly tight, because the time budget for snark workers to create proofs becomes much tighter with zkApps

@jasongitmail
Copy link
Contributor Author

Gregor explained well. We're trying to be conservative initially and then can potentially increase limits over time

@bkase
Copy link
Member

bkase commented Nov 28, 2022

Ask @deepthiskumar for the formula for the limits and translate the formula to the client side

@bkase
Copy link
Member

bkase commented Nov 28, 2022

The constants will probably change, but the formula probably won't change much

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants