Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deploy command #3

Closed
jasongitmail opened this issue Jul 7, 2021 · 3 comments
Closed

Add deploy command #3

jasongitmail opened this issue Jul 7, 2021 · 3 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@jasongitmail
Copy link
Contributor

jasongitmail commented Jul 7, 2021

  1. Add command snapp deploy <network>
  2. Exclude config file from git
  3. If config file does not exist yet, create it and create an address & private keypair and say: "Testnet address & private key created & added to config.js". (User can overwrite this with their own address & private key, if updating an existing Snapp.)
  4. If config exists, check if network name exists. If not, create address & private key as above. If yes, we'll use it.
  5. "Continue with deploy to y/n?"
  6. Create TX from proof.
  7. Send to proper network.
  • Alternatively, make it interactive and allow user to select tesnet or devnet
  • Add step to run tests first?
@jasongitmail
Copy link
Contributor Author

The UX for this is done, implemented, reviewed & merged. But we are waiting for tx construction and signing to be finished so we can plug in the pieces to make it work.

@jasongitmail
Copy link
Contributor Author

@MartinMinkov is going to finish integrating Mina Signer & the tx construction result: https://github.com/o1-labs/zkapp-cli/blob/main/src/lib/deploy.js#L126

@jasongitmail
Copy link
Contributor Author

Finished! We also added the support for zk deploy when no network alias is provided, a dropdown list of available options is shown.

ymekuria added a commit that referenced this issue Sep 5, 2023
Rename SnarkyJS to o1js in all CLI code and dependency files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants