✨ add skipper observer to flagger #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhohengassner
changed the title
|
@universam1 please review |
universam1
requested changes
Aug 4, 2020
universam1
reviewed
Aug 4, 2020
To add Skipper support we need an oberserver to watch how the canary rollout went. This commit implements point 3 from fluxcd#452 (comment) Te be able to distinct Skipper routes we need to combine the Canary data to generate the Skipper metric label.
|
nice job! LGTM |
szuecs
reviewed
Aug 4, 2020
szuecs
reviewed
Aug 4, 2020
szuecs
reviewed
Aug 4, 2020
|
|
||
| // encodeModelForSkipper replaces non word character in model with underscore to match route names | ||
| // https://github.com/zalando/skipper/blob/dd70bd65e7f99cfb5dd6b6f71885d9fe3b2707f6/dataclients/kubernetes/ingress.go#L101 | ||
| func encodeModelForSkipper(model flaggerv1.MetricTemplateModel) flaggerv1.MetricTemplateModel { |
There was a problem hiding this comment.
@aryszka here also the conversion to _ needs to be a > patch version change (unlikely that this changes anyways).
universam1
pushed a commit
that referenced
this pull request
Aug 5, 2020
according to review #2 (comment) the East-West and the annotations need to be honored here as well
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ add skipper observer to flagger
To add Skipper support we need an oberserver to watch how the canary
rollout went.
This commit implements point 3 from
fluxcd#452 (comment)
Te be able to distinct Skipper routes we need to combine the Canary
data to generate the Skipper metric label.