Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document v1.0 features #62

Closed
softwaredoug opened this issue Jul 27, 2017 · 2 comments
Closed

Document v1.0 features #62

softwaredoug opened this issue Jul 27, 2017 · 2 comments
Assignees
@softwaredoug
Milestone
1.0

Comments

@softwaredoug
Copy link
Collaborator

Update README and any other documentation to reflect v1.0 features. What other documentation do we need?
@nomoa
Copy link
Collaborator

nomoa commented Jul 27, 2017

I don't know if we should consider this a blocker but we recently found that the plugin may hit a circuit breaker in elastic, see https://phabricator.wikimedia.org/T171579 for more context.
The easy fix we plan to apply for now is setting script.max_compilations_per_minute to a large value (10000 for us).
I don't know if I'll have time to fix this properly before we release 1.0

@epugh epugh mentioned this issue Aug 8, 2017
Closed
@softwaredoug softwaredoug assigned softwaredoug and unassigned epugh Sep 9, 2017
@softwaredoug softwaredoug added this to the 1.0 milestone Sep 15, 2017
@nomoa
Copy link
Collaborator

nomoa commented Sep 21, 2017 •
edited
Loading

Just a note to say that the script.max_compilations_per_minute workaround is no longer needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@softwaredoug softwaredoug

Labels
None yet
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
3 participants
@epugh @softwaredoug @nomoa