Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor HTTP status code nitpicks in 1.0 #67

Closed
softwaredoug opened this issue Aug 18, 2017 · 2 comments
Closed

Minor HTTP status code nitpicks in 1.0 #67

softwaredoug opened this issue Aug 18, 2017 · 2 comments
Assignees
@nomoa
Milestone
1.0

Comments

@softwaredoug
Copy link
Collaborator

I noted when rebuilding the demo that

  • Trying to GET a missing feature store (to check if it exists) returns a 400, not a 404
  • PUT'ing a new feature store should return 201, instead it returns 200
@softwaredoug softwaredoug changed the title Minor HTTP nitpicks in 1.0 Minor HTTP status code nitpicks in 1.0 Aug 18, 2017
@softwaredoug softwaredoug added this to the 1.0 milestone Aug 20, 2017
@nomoa
Copy link
Collaborator

nomoa commented Sep 21, 2017 •
edited
Loading

PUT'ing a new feature store should return 201, instead it returns 200

Actually it returns a 400 with index_already_exists_exception same as the PUT /_existing_index
It's probable that this issue was created while you were still fighting with #80 ?

nomoa added a commit that referenced this issue Sep 21, 2017
@nomoa
Returns a 404 when issuing a GET on a missing store
8f23415 
Add a new GET endpoint to test if the store exists.
Only works for custom stores as GET /_ltr is already bound
to the list store action.

closes #67
@nomoa nomoa mentioned this issue Sep 21, 2017
Merged
@softwaredoug
Copy link
Collaborator Author

FIxed in #92

softwaredoug pushed a commit that referenced this issue Sep 28, 2017
@nomoa @softwaredoug
Returns a 404 when issuing a GET on a missing store
add0ce6 
Add a new GET endpoint to test if the store exists.
Only works for custom stores as GET /_ltr is already bound
to the list store action.

closes #67
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nomoa nomoa

Labels
None yet
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
2 participants
@softwaredoug @nomoa