Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Random test failures #75

Closed
nomoa opened this issue Sep 1, 2017 · 3 comments
Closed

Random test failures #75

nomoa opened this issue Sep 1, 2017 · 3 comments

Comments

@nomoa
Copy link
Collaborator

nomoa commented Sep 1, 2017 •
edited

com.o19s.es.ltr.feature.store.index.CachedFeatureStoreTests.testExpirationOnGet is failing randomly and probably others that rely on system clock.
We need to find a way to make it run nicely or disable it to avoid annoyance.
nomoa added a commit that referenced this issue Sep 1, 2017
@nomoa
Mark 2 CachedFeatureStoreTests tests as @badapple
fd44b8a 
They randomly fail, the code itself is being covered by elastic itself.
It should not be big deal to disable them while we find a proper fix
to make them stable.

relates #75
@nomoa nomoa mentioned this issue Sep 1, 2017
Merged
@softwaredoug softwaredoug added this to the 1.0 milestone Sep 6, 2017
@softwaredoug
Copy link
Collaborator

Leaving this open to fix the tests, but for 1.1 to see if it's fixable

@softwaredoug softwaredoug modified the milestones: 1.0, 1.1 Sep 15, 2017
softwaredoug pushed a commit that referenced this issue Sep 16, 2017
@nomoa @softwaredoug
Mark 2 CachedFeatureStoreTests tests as @badapple
527969a 
They randomly fail, the code itself is being covered by elastic itself.
It should not be big deal to disable them while we find a proper fix
to make them stable.

relates #75
@softwaredoug
Copy link
Collaborator

@nomoa is this still an issue?

@softwaredoug softwaredoug removed this from the 1.1 milestone Jul 13, 2018
@nomoa
Copy link
Collaborator Author

nomoa commented Jul 13, 2018

@softwaredoug I may not have enough time to properly investigate, I'll close this ticket since it's basically testing the elastic cache which is not owned by this plugin.
I'll try to find time to cleanup the test code.

@nomoa nomoa closed this as completed Jul 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@softwaredoug @nomoa