Embed mustache #64
Merged
Embed mustache #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor how stored element are handled. I think it was a bad design to consider that we could use the same representation for storing and runtime purposes. Add an optimize() step that gives a chance for StoredFeature to transform itself into another element.
Allows queries to access the FeatureVector being set. Also add FeatureSet to Feature.dotoQuery some queries may want to know the FeatureSet context.
worleydl
approved these changes
Aug 2, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor how stored element are handled. I think it was a bad design to
consider that we could use the same representation for storing and runtime
purposes.
Add an optimize() step that gives a chance for StoredFeature to transform
itself into another element.