Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert snippets that start with http into anchor links in search result pane #27

Merged
merged 4 commits into from
Nov 25, 2019

Conversation

epugh
Copy link
Member

@epugh epugh commented Nov 24, 2019

Description

Instead of adding another key word like url or link which I discovered requires custom changes in splainer-search library, and is really built aorund the concept of just one id or title or thumb, instead we look to see if this is a URL because it starts with http. In that case, instead of using the snippet, we just grab the original value and use that to construct a clickable link.

If your snippet starts with http, like in the sentence http is the protocol of the future, then you might get a bad link....

Motivation and Context

Fixes #26

How Has This Been Tested?

Manually tested. There don't seem to be specs around this.

Screenshots or GIFs (if appropriate):

Screenshot at Nov 24 17-23-23

See the link is now clickable?

Types of changes

  • [] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • [] I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • [] I have added tests to cover my changes.
  • All new and existing tests passed.

@epugh epugh merged commit 639c79b into master Nov 25, 2019
@nathancday nathancday deleted the feature-26-add-url-links branch March 13, 2020 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow a link: tag in the field spec to format a field as a Anchor Link
1 participant