Railsifying tries and cases table structure #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The |
|
Need to deal with |
|
down to |
|
so much refactoring need to remember to remove extra debugging... |
|
don't forget to fix |
epugh
changed the title
worleydl
reviewed
Jan 16, 2020
|
|
||
|
|
||
| angular.forEach(this.cases, function(c) { | ||
| // This is really ugly. |
There was a problem hiding this comment.
Revisit this code if #65 sets up lazy load for cases within a team.
worleydl
approved these changes
Jan 16, 2020
|
THanks!
… On Jan 16, 2020, at 1:06 PM, Daniel Worley ***@***.***> wrote:
@worleydl approved this pull request.
Added a comment to come back to the "ugly" mapping solution for Cases with a team.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub <#61?email_source=notifications&email_token=AAC3OIFKXM6TUN36NBA6Z73Q6CO2DA5CNFSM4KGDDFWKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCSBLN2Y#pullrequestreview-344110827>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAC3OIDZERSHRV5X3YEWT2LQ6CO2DANCNFSM4KGDDFWA>.
_______________________
Eric Pugh | Founder & CEO | OpenSource Connections, LLC | 434.466.1467 | http://www.opensourceconnections.com <http://www.opensourceconnections.com/> | My Free/Busy <http://tinyurl.com/eric-cal>
Co-Author: Apache Solr Enterprise Search Server, 3rd Ed <https://www.packtpub.com/big-data-and-business-intelligence/apache-solr-enterprise-search-server-third-edition-raw>
This e-mail and all contents, including attachments, is considered to be Company Confidential unless explicitly stated otherwise, regardless of whether attachments are marked as such.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
converting python CamelCase to Rails snake_case.
Description
Lots of updates!
Motivation and Context
At somepoint, someone is going to treat Quepid as an API, and build there own front end, say for doing ratings, or otherwise want to import/extract data via API. Having two styles of how data passes in and out of Quepid is error prone, and has bit me before.
Let's at least get the API side all the same. Pay down some tech debt!
How Has This Been Tested?
unit tests, and then manual testing and looking in the database. Especially since we don't have any true integration tests between the web app JS layer and the back end Rails app.
This is very painful ;-)