PoC for Vectara integration #826
Conversation
| @@ -55,7 +55,7 @@ angular.module('QuepidApp') | |||
| var docIds = Object.keys(docsToFetch); | |||
| var resolver = docResolverSvc.createResolver(docIds, settings, 15); | |||
|
|
|||
| if ( docIds.length > 0 ) { | |||
| if ( docIds.length > 0 && settings.searchEngine !== 'vectara') { // 'vectara' does not support doc lookup by ID | |||
There was a problem hiding this comment.
This is totally fine... And pionts to, in the future, we need some sort of "capablities" so you can be like settings.searchEngine.supportDocLookup instead ;-)
| @@ -69,7 +71,7 @@ angular.module('QuepidApp') | |||
| }); | |||
|
|
|||
| function createSearcherFromSettings(passedInSettings, queryText, query) { | |||
| let args = angular.copy(passedInSettings.selectedTry.args); | |||
| let args = angular.copy(passedInSettings.selectedTry.args) || {}; | |||
There was a problem hiding this comment.
do we need this? I have only seen this as needed when something blows up.... I see the args parameter in try.rb now supports vectara! so this may not be needed.
| if (args['fq'] === undefined) { | ||
| args['fq'] = []; | ||
| } | ||
| args['fq'].push(query.filterToRatings(passedInSettings)); | ||
| } else if (passedInSettings.searchEngine === 'vectara') { | ||
| // currently doc id filtering frequently produces 0 results | ||
| // args['query'] = args['query'].map(function addFilter(query) { |
There was a problem hiding this comment.
potentially deleteable code? I like the explicit else if for reminding us that vectara doc id filtering... Again, maybe soem day we have capablities to decide this stuff ;-).
| @@ -83,6 +81,7 @@ angular.module('QuepidApp') | |||
|
|
|||
| escapeQuery: true, | |||
| apiMethod: 'POST', | |||
| customHeaders: '', | |||
There was a problem hiding this comment.
why add it here if we remove it above? In some places we do a check for either for existence of customheaders or an actual check of if it is '', are we maybe missing that someplace?
| customHeaders: '', | ||
| fieldSpec: 'id:id', | ||
| idField: 'id', | ||
| titleField: 'title', |
There was a problem hiding this comment.
the titleField and idField... are those values "standard" in Vectara land? Do we/they want to host a demo Vectara that we can document and use in the wizard, kind of like the TMDB dataset? And add to the https://github.com/o19s/quepid/wiki/Troubleshooting-Opensearch-and-Quepid#demo-opensearch-indexes-with-the-tmdb-dataset type page for Vectara???
| </div> | ||
| </div> | ||
| </div> | ||
| </div> |
There was a problem hiding this comment.
thanks! this looks like some nasty html nesting bug!
…ll except in the test construction?
This brings in a simple integration into the Vectara search engine.
This requires the respective PR in splainer-search to be merged.
Currently, this is mainly supporting sending queries and getting documents back from Vectara.
Some limitations:
responsesfromdocuments(where there can be multiple response for a single document). We are currently extracting the documents from the response.