-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Direct file upload for substitution #60
Conversation
docs/compendium/substitute.md
Outdated
"base": "climate-timeseries.csv", | ||
"overlay": { | ||
"filetype": "text/plain", | ||
"filename": "substitution.txt", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't be the input file of same datatype of the base-file ?
In general there is not that difference between .csv and .txt, but in the substitution there it is right now important that the datatype is the same ( because this would cause the need of editing the main.Rmd where this file is gonna get read). Or am i wrong?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, how do you know that the .txt file does not contain comma-seperated values?
I updated the example accordingly.
@Fmazin is there any way to model "drafts" in an Open API spec? There is this PR with a few good ideas, and I'm about to open another one, changing and/or extending the API. I'm wondering how to best capture that. |
Outdated, spec is now based on Swagger. Also unclear if this will be realised. |
A draft to support direct file upload during substitution, i.e. a user selects a file from the browser instead of from the overlay ERC.
There is an Angular directive: https://github.com/adonespitogo/angular-base64-upload
@TeKraft This should be straightforward in Node.js on the server, see http://www.hacksparrow.com/base64-encoding-decoding-in-node-js.html