Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Direct file upload for substitution #60

Closed
wants to merge 7 commits into from

Conversation

nuest
Copy link
Member

@nuest nuest commented Oct 19, 2017

A draft to support direct file upload during substitution, i.e. a user selects a file from the browser instead of from the overlay ERC.

There is an Angular directive: https://github.com/adonespitogo/angular-base64-upload

@TeKraft This should be straightforward in Node.js on the server, see http://www.hacksparrow.com/base64-encoding-decoding-in-node-js.html

@nuest nuest requested review from jansule and TeKraft October 19, 2017 14:12
"base": "climate-timeseries.csv",
"overlay": {
"filetype": "text/plain",
"filename": "substitution.txt",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't be the input file of same datatype of the base-file ?
In general there is not that difference between .csv and .txt, but in the substitution there it is right now important that the datatype is the same ( because this would cause the need of editing the main.Rmd where this file is gonna get read). Or am i wrong?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, how do you know that the .txt file does not contain comma-seperated values?

I updated the example accordingly.

@nuest nuest removed the request for review from jansule November 3, 2017 20:33
@o2r-project o2r-project deleted a comment from TeKraft Nov 8, 2017
@nuest
Copy link
Member Author

nuest commented Oct 8, 2020

@Fmazin is there any way to model "drafts" in an Open API spec?

There is this PR with a few good ideas, and I'm about to open another one, changing and/or extending the API. I'm wondering how to best capture that.

@nuest
Copy link
Member Author

nuest commented Nov 20, 2020

Outdated, spec is now based on Swagger. Also unclear if this will be realised.

@nuest nuest closed this Nov 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants