Snap version 2.11.0 fail to run

[Czaki]

When trying to use onefetch from snap its fails with Error: please run onefetch inside of a non-bare git repository

$ onefetch --help                                                         
onefetch 2.11.0

When using version from apt everything works

$ onefetch --help   
onefetch 2.10.2

My system:

$ lsb_release -a 
No LSB modules are available.
Distributor ID:	Ubuntu
Description:	Ubuntu 21.10
Release:	21.10
Codename:	impish  

[o2sh]

When trying to use onefetch from snap its fails with Error: please run onefetch inside of a non-bare git repository

Are you sure that you ran onefetch inside of a git repository? see the Getting Started section in the wiki.

[Czaki]

Are you sure that you ran onefetch inside of a git repository? see the Getting Started section in the wiki.

Yes. I run both version in same repository. I'm not only one:

https://www.reddit.com/r/linux/comments/sxarym/neofetch_for_git_repository/hxszgzn/?utm_source=reddit&utm_medium=web2x&context=3

[o2sh]

Indeed, you're not the first one to have encountered this issue #335

Unfortunately, I can't reproduce on my machine.

[Czaki]

Did you have any hint how I could got more verbose output that may help you? Maybe this is somehow related to snap permissions?

[spenserblack]

I think we may want to adjust this line

onefetch/src/info/repo.rs

Line 359 in 3de0a37

Ok(repo.is_ok() && !repo?.is_bare())

When repo.is_ok() is false, it's likely short-circuiting the boolean expression, resulting in Ok(false) being returned when the wanted behavior is likely that !repo?.is_bare() would return an Error (due to the ?). This is likely leading to confusing errors that aren't due to the repo being bare.

[Czaki]

I just compile onefetch from the source and it works without problem.

When building snap using snapcraft it also works. So modifying code also will not help to solve this.

But when install from snap store it does not work.

[spenserblack]

This is just a guess, but I'm thinking maybe the snap store version isn't properly linking with some libraries, which causes repo.is_ok to return false.

Edit: Likely related to #335

[Czaki]

there are no such error messages.
Maybe it is possible to create a new snap release (maybe using a beta channel) to check this? Or some more verbose version that will print additional debug information?

[spenserblack]

there are no such error messages.

Sorry, I didn't mean that you're getting that specific error, just that it's likely that the error is caused by a failure to link to a library. But, due to boolean short-circuiting, that error is silently ignored.

Here is an example that I hope clarifies why the error you're seeing isn't actually the root cause. Either way I would consider this a bug where onefetch is hiding the appropriate error message.
https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=9ca3f3493109fd43478394b29559d1c6

[Czaki]

I see. Maybe @o2sh could create a new release that will allow debugging this.

[o2sh]

I followed @spenserblack's suggestion and temporarily removed the first condition in the is_valid() check.

@Czaki, you can test this version via sudo snap install onefetch --edge

[Czaki]

$ onefetch ../PartSeg              
Error: failed open - '/etc/gitconfig' is locked: Permission denied; class=Os (2); code=Locked (-14)                                                                                                                                                              /0,3s

where

$ cat /etc/gitconfig
[filter "lfs"]
	smudge = git-lfs smudge -- %f
	process = git-lfs filter-process
	required = true
	clean = git-lfs clean -- %f  

Based on fast google it may be connected with install git-lfs and by default, this file is absent in most installations.
Later I read that snap by default has to access only files in the user home directory.

I found a similar issue profclems/glab#597 with a simple solution profclems/glab#599

[Czaki]

I see your message yesterday evening, but when try to test it today it is missed. So I cannot check if it works.

[o2sh]

Yeah sorry, I thought I had a solution but I was wrong 😞

As a quick and easy fix, would you consider making your gitconfig global wide instead of system wide -> mv /etc/gitconfig ~/.gitconfig ?

[Czaki]

As a quick and easy fix, would you consider making your gitconfig global wide instead of system wide -> mv /etc/gitconfig ~/.gitconfig ?

This will fix of course. For me, I could even use the compiled version. But this is not a proper solution for his problem.
And it is not a solution for all users where sometimes you need systemwide configuration files for all users. There need to be at least some proper error message.

[o2sh]

Following 125c610, a manual review was automatically created and is currently pending: https://dashboard.snapcraft.io/snaps/onefetch/revisions/1855/

[o2sh]

https://forum.snapcraft.io/t/system-files-request-for-onefetch/28963

[o2sh]

The request has been approved. Onefetch's snap (edge channel) has been granted read access to:

• /etc/gitconfig
• $HOME/.gitconfig
• $HOME/.config/git/config

[Czaki]

Just installed the version from edge and it works :)

Tested also non-edge and it still fails (so no other workaround happens and this solution is good).

[o2sh]

Since the v.2.12.0 release, this should also work on the stable channel.